search

lando / vitepress-theme-default-plus

The VitePress Default Theme with a little more POWAH
https://vitepress-theme-default-plus.lando.dev/
GNU General Public License v3.0
21 stars 2 forks source link

fix(defaults): don't enable carbonAds by default #26

Closed mtdvlpr closed 4 months ago

mtdvlpr commented 4 months ago

There should not be a default value for carbonAds, especially since it can't be unset (setting undefined will just be overridden by your default).

netlify[bot] commented 4 months ago

Deploy Preview for vitepress-theme-default-plus ready!

Name Link
Latest commit d2c167c834f1887e12e4d76aaf9775782634aff7
Latest deploy log https://app.netlify.com/sites/vitepress-theme-default-plus/deploys/65cfca415c2643000808d04f
Deploy Preview https://deploy-preview-26--vitepress-theme-default-plus.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse		 1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

pirog commented 4 months ago

@mtdvlpr good call. oversight on our part. thanks for the contribution and def keep them coming. still beta and theme development is not the main thing we do so im sure there are things to fix ;)