Assignment 2 submission

[landoan]

Hi @coderschoolreview. I have completed my 2nd assignment. You can review here :)

[hoksilato]

Hi @landoan, nice work with impressive UI homework :+1:

The goals of this homework are:

• to know how to implement authentication from scratch in Rails with the help of the has_secure_password class method and the brypt gem (while understanding what they do under the hood)
• to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for belongs_to/has_many, using has_many :through and building more advanced queries by chaining where, order, and merge
• to build more complex forms in views that involve multiple models.

Quick review:

• Impressive UI.
• Good work with auto-complete recipient feature.
• Excellent work with optional functionalities.

Some small issues:

• Can't see validation errors notice on sign up form.

Suggestions

• Should validate the input for all of your forms.
• It's good to do things your way for experiences, but we need a method to get current user information all over our app and the best way to do is using helper_method, before_action and place it in application_controller.rb. Same with other methods that you use all over your app. (g.e. require_login or authorize_user?)

Gemfile:

• You should include rails_12factor gem in production group because we only need it for production.

Routes file:

• There are some duplicates on your routes. You can use resources for routing if no need to customize. (g.e. routes for friendship)

Congrats again on the submission and thanks for you hard work. Everyone has limited time; it's good to see you finished all functionalities. Keep your good work, you're one of our favorite students :100: Let us know if you have any feedback.