search

landonf / XcodePostFacto

Xcode 6.3 for Mac OS X 10.9
Other
68 stars 9 forks source link

Fix pngcrush crash #6

Closed gwynne closed 9 years ago

gwynne commented 9 years ago

pngcrush apparently only comes in an i386 slice. xpf-bootstrap, meanwhile, can't be built universal. The result is an abort() in dyld when pngcrush is run by the asset catalog compiler. Therefore, just unsetenv() to prevent it from being loaded into child processes.

landonf commented 9 years ago

Do we just need a universal PLPatchMaster to allow building xpf universal?

vista980622 commented 9 years ago

A universal PLPatchMaster would be amazing!

landonf commented 9 years ago

I just committed i386 support to the PLPatchMaster repository; should be possible to use this for a universal XcodePostFacto.

landonf commented 9 years ago

@gwynne: I just enabled the 32-bit build for xpf-bootstrap and friends; I believe this resolves the issue, but I sure wouldn't mind a sanity-check.

gwynne commented 9 years ago

Confirmed, the 32-bit build solves the issue and doesn't appear to cause any regressions.