search

landro / TesTcl

when you don't have the balls to test your F5 BIG-IP iRules directly in production
https://testcl.com
BSD 3-Clause "New" or "Revised" License
98 stars 30 forks source link

tests should exit with a status reflecting whether they passed or not #36

Closed nhemingway closed 9 years ago

nhemingway commented 9 years ago

In order that test frameworks can tell which tests in a suite passed and failed, and to return a result for a whole test suite

landro commented 9 years ago

how about making the 'stats' (the one that can be used to print the number of failing tests) command return the number of failing tests, @nhemingway ?

nhemingway commented 9 years ago

Hi,

Locally, I added:

::tcl::exit $nbOfTestFailures

to stats as you suggest. But that makes several of the TesTcl tests fail.

I'm digging as we speak, but not knowing tcl particularly, I'm open to suggestions at this point....

Is there an IRC channel where we can discuss?

Neil

On 12 May 2015 at 15:04, Stefan Magnus Landrø notifications@github.com wrote:

how about making the 'stats' (the one that can be used to print the number of failing tests) command return the number of failing tests, @nhemingway https://github.com/nhemingway ?

— Reply to this email directly or view it on GitHub https://github.com/landro/TesTcl/issues/36#issuecomment-101294942.

landro commented 9 years ago

Just committed 131a04aff243d505e078271c6380f23494bc9cc2 to 36_tests_should_exit_with_a_status_reflecting_whether_they_passed_or_not branch

Could you give that a shot, and see if it works for you @nhemingway ?

nhemingway commented 9 years ago

That works fine

landro commented 9 years ago

9c1e019ab90d2b8bab6ce2071f85524535bfbba9 fixes this issue

nhemingway commented 9 years ago

Excellent - thx

nhemingway commented 9 years ago

I'll have another issue and pull req for you once I've figured out how to get tcl to do IP address finagling