search

landro / TesTcl

when you don't have the balls to test your F5 BIG-IP iRules directly in production
https://testcl.com
BSD 3-Clause "New" or "Revised" License
98 stars 30 forks source link

Iruleuri.tcl update to URI::compare, URI::encode and URI::decode #56

Closed andy-mcgrath closed 6 years ago

andy-mcgrath commented 6 years ago

Update to URI::encode and URI::decode to use string map.

URI::encode has been added to %7e / ~ excluding letter, number and some select symbols. URI::decode decodes all characters up to %7e / ~ and string map used to map both upper and lower case charaters.

e.g. %2b and %2B map to + using string map {"%2b" "+" "%2B" "+"}

Reference using UTF-8 from HTML URL Encoding Reference

landro commented 6 years ago

Nice work, @apextc ! I'll try to review and merge this within the next few days!

andy-mcgrath commented 6 years ago

@landro I have an update to the URI::compare as well, do you want it added to this pull request or would you prefer me to create a new one so you can review independently?

If you want to quickly take a look - apextc/TesTcl commit 'rewrite testcl::URI::compare'

landro commented 6 years ago

Same PR is Ok

Sendt fra min iPhone

  1. nov. 2018 kl. 14:06 skrev apextc notifications@github.com:

@landro I have an update to the URI::compare as well, do you want it added to this pull request or would you prefer me to create a new one so you can review independently?

If you want to quickly take a look - apextc/TesTcl commit 'rewrite testcl::URI::compare'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

landro commented 6 years ago

Great work @apextc !