search

landscapeio / prospector

Inspects Python source files and provides information about type and location of classes, methods etc
GNU General Public License v2.0
1.94k stars 171 forks source link

[BUG] Vulture doesn't report `unused method` under Prospector #598

Open rpatterson opened 1 year ago

rpatterson commented 1 year ago

Describe the bug

Running Vulture directly reports unused method:

$ vulture ./src/foo/
src/foo/bar.py:##: unused method 'qux' (##% confidence)

But running it under Prospector reports nothing:

$ prospector ./src/foo/
Check Information
=================
         Started: ####-##-## ##:##:##.######
        Finished: ####-##-## ##:##:##.######
      Time Taken: #.## seconds
       Formatter: grouped
        Profiles: .prospector.yaml, full_pep8, doc_warnings, strictness_veryhigh, member_warnings
      Strictness: from profile
  Libraries Used: 
       Tools Run: bandit, dodgy, mccabe, mypy, profile-validator, pycodestyle, pydocstyle, pyflakes, pylint, vulture
  Messages Found: 0
 External Config: pylint: ./pyproject.toml

Environment:

rpatterson commented 1 year ago

I'm guessing this is because Prospector hard codes the vulture checks to perform? Maybe it would be best to find someway to let Vulture define the list of checks it performs so that they're included in Prospector as Vulture changes?