Describe the bug
Sometimes when sending a mission the process handler which processes the arriving mission seems to be firing more than once.
To Reproduce
Steps to reproduce the behavior:
Send a colony ship on a colonize mission.
Recall the fleet after a few seconds.
Wait for the fleet to come back.
Sometimes the message that says the fleet has returned appears twice. Note: this does not happen always, just in some cases.
Expected behavior
The mission process logic to only fire once and thus only one "fleet has returned" message received.
Screenshots
Additional context
Not sure yet what the root cause is and why it's not happening always. Might have to do with parallel requests which both trigger the update logic and causing a race condition where two requests are simultaneously processing updates.
Currently planet updates happen on every request. See PlanetService::update() which contains the updateFleetMission() call. Perhaps we will need to refactor the planet update logic to add a locking mechanism or move processing logic to an event queue or similar.
Describe the bug Sometimes when sending a mission the process handler which processes the arriving mission seems to be firing more than once.
To Reproduce Steps to reproduce the behavior:
Expected behavior The mission process logic to only fire once and thus only one "fleet has returned" message received.
Screenshots
Additional context Not sure yet what the root cause is and why it's not happening always. Might have to do with parallel requests which both trigger the update logic and causing a race condition where two requests are simultaneously processing updates.
Currently planet updates happen on every request. See
PlanetService::update()which contains theupdateFleetMission()call. Perhaps we will need to refactor the planet update logic to add a locking mechanism or move processing logic to an event queue or similar.