terraformer planet field bonus logic

lanedirt / OGameX

Open-source OGame redesign clone built with Laravel 11.x.

https://main.ogamex.dev

MIT License

59 stars 24 forks source link

Closed jackbayliss closed 4 weeks ago

jackbayliss commented 1 month ago

This should handle #392

Also adds a variety of tests - feel free to let me know any adjustments.

jackbayliss commented 1 month ago

@lanedirt Should hopefully now be sorted, did spot a previous test I did where I missed a whitespace after the closing brace, so sorted that too.

jackbayliss commented 4 weeks ago

@lanedirt Good catch, must of missed it- I've now adjusted it.

It would be ideal if we could add this into the code analysis as I guess everyone has their own style 😃

jackbayliss commented 4 weeks ago

Not sure why the test failed! Looks to be a bit flaky, but I believe this is already in another issue?

lanedirt commented 4 weeks ago

Not sure why the test failed! Looks to be a bit flaky, but I believe this is already in another issue?

Yes it looks like it's the same issue as reported in #401. Have to look into fixing that one soon. 🐛 Re-running tests now.

Edit: tests succeeded. Merging now 🚀 !