search

lanej / zendesk2

Zendesk API V2 client using Cistern
http://lanej.io/zendesk2/
MIT License
25 stars 28 forks source link

Zendesk2::Client::Real created incorrectly with mock.zendesk.com instead of using defined subdomain in ~/.zendesk2 #28

Closed jasonwbarnett closed 10 years ago

jasonwbarnett commented 10 years ago

This line isn't necessary because of #zendesk_url + #form_zendesk_url and it only creates problems. I don't have a wider context, so this may be wrong. In my immediate testing this seemed to resolve my issue.

lanej commented 10 years ago

@jasonwbarnett i was thinking about removing subdomain as a valid parameter entirely and forcing people to just specify a url. thoughts?

jasonwbarnett commented 10 years ago

That's probably best. It would just require necessary documentation updates, obviously.

lanej commented 10 years ago

i'll take this and release a major with all the url formation parameters removed in favor of just url.