search

langchain-ai / langchain-aws

Build LangChain Applications on AWS
MIT License
106 stars 86 forks source link

Fix ChatBedrock to enable "test_stop_sequence" integration test #234

Open 3coins opened 1 month ago

3coins commented 1 month ago

Add stop attribute to ChatBedrock and ChatBedrockConverse classes to fix the standard "test_stop_sequence" integration tests.

tests/integration_tests/chat_models/test_standard.py::TestBedrockStandard::test_stop_sequence FAILED
tests/integration_tests/chat_models/test_standard.py::TestBedrockUseConverseStandard::test_stop_sequence FAILED
Forma-Lin commented 6 days ago

Hello @3coins, is anyone working on this issue right now? If no, may I take it?

3coins commented 6 days ago

@Forma-Lin Plz feel free to work on this. Let me know if I can help with anything to get you started. Assigned the issue to you.