Add min_score_confidence support for the Bedrock KB retriver

langchain-ai / langchain-aws

Build LangChain Applications on AWS

MIT License

63 stars 47 forks source link

Add min_score_confidence support for the Bedrock KB retriver #49

Closed ihmaws closed 1 month ago

ihmaws commented 1 month ago

Add `min_score_confidence` support for the Bedrock KB retriver

add min_score_confidence field to AmazonKnowledgeBasesRetriever class
add unit tests and integration tests to test score
update kendra retriver _filter_by_score_confidence doc string

Closes: https://github.com/langchain-ai/langchain-aws/issues/48

3coins commented 1 month ago

cc @rozerarenu to review this PR.

ihmaws commented 1 month ago

Thanks for having a look and approving @rozerarenu and @3coins!

Any thoughts on when this would be merged and put into a release? I'm currently extending the AmazonKnowledgeBasesRetriever and using the code in this PR in an application today, but will switch to directly using it from langchain once released.

Let me know if there is anything else I can help with to get this into a release.