Closed tdigangi closed 1 month ago
/gcbrun
@jzaldi PTAL
I'm actually wondering whether we need an integration test for that. Maybe a unit test that checks that we pass a parameter to the corresponding API call will be enough for the first step.
It looks like from_components is reliant upon a endpoint existing within the environment, thus I have put it in an integration test. I started to craft a unit test, but paused when I saw that endpoint requires an endpoints exists.
I believe it is an integration needed but this would have to be part of the infra setup used when these test execute. Let me know how you wish to proceed.
/gcbrun
I am unable to debug the cloud build error due to a lack of permission on the project in which they are placed. My best guess would be the endpoint is not set up with PSC.
@tdigangi I'm sorry for the delay, I'm looking for smbd from the Vertex Vector Store team to take a look and help with the review.
Add private_service_connect_ip_address to VectorSearchVectorStore via the from_components() method. Added placeholder integration test for private PSC endpoint.
Please provide guidance on how to update integration tests. Also if you wish to add more MatchingEngineIndexEndpoint properties in this PR or have a opinion on a more complex data structure(I.E. via kwargs or dict) to add properties provide this guidance and I will update accordingly.