search

langchain-ai / langchain-google

MIT License
74 stars 78 forks source link

Add batch size param for embeddings #255

Closed adamvig96 closed 1 month ago

adamvig96 commented 1 month ago

Fix #254

lkuligin commented 1 month ago

/gcbrun

lkuligin commented 1 month ago

thanks for your contribution! could you add a unit test for this change, please?

lkuligin commented 1 month ago

and feel free either to ignore the codespell error, or modify pyproject.toml for genai similar to this change: https://github.com/langchain-ai/langchain-google/pull/251/files#diff-8552fd3e5ce09f06c116d262b115beee68374a79bea32f62bffaf2852b159b24

It's actually my bad, I didn't realize codespell will break for other libraries too.

adamvig96 commented 1 month ago

Thanks, I added the unit test. I see that the typo is being handled in #257 so ignoring it.