Closed rgupta2508 closed 5 days ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
langchain | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 28, 2024 9:54am |
@baskaryan Please review
@ccurme Can you please review this as well.
upsert same thing which provided in add_text method
Thanks
@rgupta2508 can you clarify, are these two equivalent?
milvus.upsert_texts(texts, metadatas=metadatas)
and
from langchain_core.documents import Document
documents = [Document(text, metadata=metadata) for text, metadata in zip(texts, metadatas)]
milvus.upsert(documents=documents)
i.e., is this a convenience method, or is there missing functionality?
@rgupta2508 can you clarify, are these two equivalent?
milvus.upsert_texts(texts, metadatas=metadatas)
and
from langchain_core.documents import Document documents = [Document(text, metadata=metadata) for text, metadata in zip(texts, metadatas)] milvus.upsert(documents=documents)
i.e., is this a convenience method, or is there missing functionality?
Ohh got it, thanks for clarification.
Closing this PR
Upsert texts to the Milvus vectorstore. This is based on upsert data based on add_text functionality In case metadata need to upsert in milvus, Metadata keys will need to be present for all inserted values. At the moment there is no None equivalent in Milvus.