langchain-ai / langchain

🦜🔗 Build context-aware reasoning applications
https://python.langchain.com
MIT License
86.01k stars 13.34k forks source link

community: add support for sentence window retrieval in Qdrant.py by enabling integer ids when using Qdrant.from_texts(....) #21553

Open sagarvadodaria opened 2 weeks ago

sagarvadodaria commented 2 weeks ago

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 3:38pm
sagarvadodaria commented 1 week ago

@baskaryan / @efriis / @eyurtsev , just wanted to bring this PR to your attention. This adds a new chunk_window_retrieval_search for Qdrant which is based on sentence window.

sagarvadodaria commented 1 week ago

@baskaryan / @efriis / @eyurtsev , just wanted to bring this PR to your attention. This adds a new chunk_window_retrieval_search for Qdrant which is based on sentence window.

@baskaryan / @efriis / @eyurtsev

Hello again, just wanted to check if we can hear your thoughts about this, so that we can plan accordingly. Do you agree with this approach or this has no chance. Either way, it would help us decide our design. At the bare minimum we should add the support for adding Integers as PointIds in Qdrant. At this point, Qdrant.fromtexts(..) method only accepts List of String. Any reason not to accept List of Integers as well since Qdrant does support that?