ChatOllama is missing the parameters seed and base_url

chriss1245 commented 1 month ago

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code

When running:

from langchain_ollama import ChatOllama
llm = ChatOllama(
    model=MODEL_NAME,
    base_url=BASE_URL,
    seed=42
)

The parameters base_url and seed get ignored. Reviewing the code of this instance, I see that the class definition is missing these attributes.

Error Message and Stack Trace (if applicable)

No response

Description

Regarding seed, in PR 249 in ollama, this feature was added to allow reproducibility of the experiments. Regarding base_url, since ollama allow us to host llms in our own servers, we need to be able to specify the url of the server.

Plus in OllamaFunctions from the package langchain_experimental does provide support to this.

System Info

langchain==0.2.11 langchain-chroma==0.1.2 langchain-community==0.2.10 langchain-core==0.2.23 langchain-experimental==0.0.63 langchain-groq==0.1.6 langchain-ollama==0.1.0 langchain-text-splitters==0.2.2

noggynoggy commented 1 month ago

I'm looking into it. I'll PR if I come to a nice solution

noggynoggy commented 1 month ago

There are actually more Options missing. If you compare whats available with what is implemented, you can see that there are way more options. I have to be honest though, I don't know what half of the options even do. So I'll focus on the base_url and the seed for now. The URL part i have working already.

chriss1245 commented 1 month ago

Sounds good. To be honest me neither. I mentioned seed and base_url cause i use those. Thanks a lot!

Talhavaival1 commented 1 month ago

@noggynoggy I also use Base URL , would appreciate if you could create a PR and get it merged.

noggynoggy commented 1 month ago

The base_url functionality was added by #24719. Maybe ill add the other Parameters later with a PR

michaelgfeldman commented 1 month ago

Can you please add seed parameters. It's also kind of an essential one.

noggynoggy commented 1 month ago

@chriss1245 you can close this issue. Both have been implemented.

The latest release does not include the changes yet, so in the meantime:

wget https://raw.githubusercontent.com/langchain-ai/langchain/master/libs/partners/ollama/langchain_ollama/chat_models.py -O .venv/lib/python3.11/site-packages/langchain_ollama/chat_models.py

make sure the path works for you (venv name, python version)

chriss1245 commented 1 month ago

Sure, thanks a lot!

Steffanic commented 1 month ago

Thanks for doing this, I've been so confused!

langchain-ai / langchain