langchain-ai / langchain

🦜🔗 Build context-aware reasoning applications
https://python.langchain.com
MIT License
95.2k stars 15.44k forks source link

Update Poetry version, to current latest (1.8.4) #28194

Open ulgens opened 4 days ago

ulgens commented 4 days ago

Update all Poetry versions to the current latest, 1.8.4 .

I was checking how lock files are managed and found out that even though the files are generated - updated with the current latest version of Poetry, the version used in CI and Dockerfile was outdated.

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **langchain** | ⬜️ Ignored ([Inspect](https://vercel.com/langchain/langchain/G8qyc346Lae3yZtZX6baQtTqwh6x)) | [Visit Preview](https://langchain-git-fork-ulgens-updatepoetry184-langchain.vercel.app) | | Nov 18, 2024 11:28pm |
efriis commented 3 days ago

was this creating issues? in general we don't update these versions for each release, because in CI poetry is just used for installing from lockfiles.

ulgens commented 3 days ago

@efriis I wasn't going for a fix, this was more of a maintenance task. As far as I understood, CI config has been neglected for a while. It's expected to install those lock files with the version that locked them because the file format changes by the versions and using the latest comes with performance issues.

I wouldn't push for updating the config with every patch release of the tools, but I think it's good to merge this PR for mainly two reasons:

ulgens commented 2 days ago

Hey again, I came up with another pro argument for this exact version.

https://github.com/python-poetry/poetry/releases/tag/1.8.4

Poetry validates Python 3.13 support with version 1.8.4, so any version older than that is not officially compatible with Python 3.13. Considering there are not many blockers for langchain's 3.13 support, 3.13 support at poetry level is a nice thing to have.

efriis commented 1 day ago

sounds good! will probably wait to merge this until after thanksgiving because I'm ooo next week, and we've had some unexpected issues pop up in the past with other CI pipelines that get impacted by poetry upgrades