search

langchain-ai / langchainjs

🦜🔗 Build context-aware reasoning applications 🦜🔗
https://js.langchain.com/docs/
MIT License
12.71k stars 2.19k forks source link

fix[community]: Fixed missing tool_choice in call options of chat IBM #7192

Closed FilipZmijewski closed 4 days ago

FilipZmijewski commented 4 days ago

Fixed missing tool_choice in call options of chat model. Was not aware of this issue until actually looking into langgraph implementation, maybe there could be an option to avoid such problems in the future?

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Nov 12, 2024 9:13am
1 Skipped Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **langchainjs-api-refs** | ⬜️ Ignored ([Inspect](https://vercel.com/langchain/langchainjs-api-refs/6oG7PT7m4LX2LV1dRkNV3mNw98n6)) | | | Nov 12, 2024 9:13am |
FilipZmijewski commented 4 days ago

@jacoblee93 This is very simple fix if you could have a look at it, please. Did not manage to see the issue until updating package in langgraph based project. And receiving and error that types on llm do not match. Thank you.

Screenshot 2024-11-12 at 10 19 36

Fixed in this PR.

jacoblee93 commented 4 days ago

Thanks! See comment but happy to merge and cut for now

Are you sure this fixes it actually?

FilipZmijewski commented 4 days ago

yes, checked locally with langgraph, will fix accordingly to your comment in the next PR then.