langchain-ai / opengpts

MIT License
6.31k stars 829 forks source link

Bug fix: Change `ollama_base_url` to `base_url` in `ChatOllama` constructor #280

Closed andrewnguonly closed 2 months ago

andrewnguonly commented 2 months ago

_OllamaCommon.base_url: https://github.com/langchain-ai/langchain/blob/master/libs/community/langchain_community/llms/ollama.py#L32

weipienlee commented 2 months ago

also model_name => model

weipienlee commented 2 months ago

In addition, I fooled around with it it too and found that tool/function calling is not working with the ChatOllama class. Maybe therefore it should be only available for the chat tap??

andrewnguonly commented 2 months ago

also model_name => model

Resolved ✅: https://github.com/langchain-ai/opengpts/pull/278

In addition, I fooled around with it it too and found that tool/function calling is not working with the ChatOllama class. Maybe therefore it should be only available for the chat tap??

Fair point. If I have some free time I will test it out as well.