search

langchain-ai / opengpts

MIT License
6.31k stars 829 forks source link

20240409 remove unsupported --start-interval since docker 4.21.1 #284

Closed box9527 closed 2 months ago

box9527 commented 2 months ago

it causes issue "failed to solve: dockerfile parse error on line 30: unknown flag: start-interval" when build.

mkorpela commented 2 months ago

I could not reproduce this on OSX with

❯ docker --version
Docker version 25.0.3, build 4debf41

I ran

cd backend
docker build . -t testing-opengtps-backend

Could you explain the conditions for reproducing the problem?

box9527 commented 2 months ago

Hi, mkorpela, I just clone the newest commit (d6e62ff) and execute docker-compose build then crash on this issue. I checked the issues of docker and found this solution as my PR. If I get any misunderstanding please forgive me. Here comes my local environment variables:

docker info
Client:
 Version:    24.0.6
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.11.2-desktop.4
    Path:     /Users/carl/.docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.21.0-desktop.1
    Path:     /Users/carl/.docker/cli-plugins/docker-compose
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.0
    Path:     /Users/carl/.docker/cli-plugins/docker-dev
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.20
    Path:     /Users/carl/.docker/cli-plugins/docker-extension
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v0.1.0-beta.7
    Path:     /Users/carl/.docker/cli-plugins/docker-init
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     /Users/carl/.docker/cli-plugins/docker-sbom
  scan: Docker Scan (Docker Inc.)
    Version:  v0.26.0
    Path:     /Users/carl/.docker/cli-plugins/docker-scan
  scout: Command line tool for Docker Scout (Docker Inc.)
    Version:  0.24.1
    Path:     /Users/carl/.docker/cli-plugins/docker-scout

My MacOs:

macOS Sonoma 14.4.1（23E224）

I still can reproduce it on my local:

docker-compose build [+] Building 0.2s (2/2) FINISHED docker:desktop-linux => [backend internal] load build definition from Dockerfile 0.0s => => transferring dockerfile: 984B 0.0s => [backend internal] load .dockerignore 0.0s => => transferring context: 2B 0.0s failed to solve: dockerfile parse error on line 30: unknown flag: start-interval

box9527 commented 2 months ago

Hi, mkorpela, I think it might be my local problem, because I found some docker desktop issues on my local. After I totally uninstalled my desktop and reinstall the newest version, says docker engine version 25.0.3 just like yours, and I can build it as normally. I'll close this PR. Sorry to bother you and thanks a lot for your time and response. :D