search

langchain-ai / opengpts

MIT License
6.3k stars 827 forks source link

Fix public assistants endpoint #318

Closed bakar-io closed 2 months ago

bakar-io commented 2 months ago

Frontend no longer uses this endpoint so there is no use for shared_id. Without that, the endpoint was always returning an empty list.

andrewnguonly commented 2 months ago

The frontend still references the shared_id query param here: https://github.com/langchain-ai/opengpts/blob/main/frontend/src/components/Config.tsx#L419

I don't know if this code is functional or useful. Maybe consider removing this reference as well.

bakar-io commented 2 months ago

Good point.

const link = currentLink.includes(props.assistantId)
    ? currentLink
    : currentLink + "?shared_id=" + props.assistantId;

includes always returns true. Will remove.

bakar-io commented 2 months ago

@andrewnguonly Removed. Can you have another look please?