search

langcog / childes-db-shiny

2 stars 2 forks source link

Frequency Counts app throws error when you add more than one word (pr) #8

Closed kemacdonald closed 6 years ago

kemacdonald commented 6 years ago

Not sure if I'm using the interface correctly, but this is one of the first things I tried:

screen shot 2017-10-03 at 11 14 17 am
amsan7 commented 6 years ago

this one's related to other issue in that empty data will break facet_wrap. so the word "shoe, dog" is not found. it's fixed, but now a little concerned about whether we should add support for multiple words / is it obvious that you can only enter 1 word

@mcfrank any reason we used textInput for word and not selectizeInput? Too many tokens?

smeylan commented 6 years ago

Looks like there is still a problem here: the date picker changes to NaN- NaN when a second word is added

screen shot 2017-11-02 at 9 23 31 am
amsan7 commented 6 years ago

It happens when any word not in the DB is entered - but yeah it's not great to show empty plot and NaNs. Probably a better way to convey that word isn't found / we should add support for multiple words