langcog / childesr

R interface to childes-db
14 stars 6 forks source link

functions return age in days when tutorial says to use months #17

Closed amsan7 closed 6 years ago

amsan7 commented 6 years ago

https://langcog.github.io/childesr//reference/get_tokens.html

Let's use months. I might change the underlying db format because in all of our use cases I've seen days converted to months.

mcfrank commented 6 years ago

Months are not a thing though! A month is not a scientific unit. That’s why the underlying architecture needs to be days.

amsan7 commented 6 years ago

True. Although working with the original "3;4" age encodings is the underlying problem I suppose. I'll keep age in days in the db. As for the interface, do you think users should be searching by days or months? They'll be doing things like 18*30 or 18*30.5, which also seems undesirable

dyurovsky commented 6 years ago

I think in the interface we still want to use months. not sure what the right choice is on the backend. We could have a month column as well. That's redundant, but maybe clear?

amsan7 commented 6 years ago

Yeah. Another thought is to just always convert days to months when returning data to the user

mcfrank commented 6 years ago

ok, consensus - days on the backend, months on the frontend. make sure to use the correct conversion (including leap years but not on the 100 year etc.)