search

langcog / experimentology

Experimentology textbook
https://langcog.github.io/experimentology/
Other
42 stars 18 forks source link

namespace fixes #193

Closed poldrack closed 1 year ago

poldrack commented 1 year ago

This includes fixes for several tidyverse functions that were not being properly found without their full namespace specified.

Renv also made changes to activate.R - I am not expert in renv so I don't actually know what those are about. if you'd like me to kill those before merging just let me know.

mcfrank commented 1 year ago

hey! we did some namespace fixes on our own but it seems like this PR now has some undergrad stuff? should we try to merge it?

poldrack commented 1 year ago

Ah, yes,this PR is from the undergrad branch, which has subsequently gained a ton of UG-specific changes. I'm going to close this one for now without merging, and I will pull any specific changes required for the docker build into main and then submit another PR.

mcfrank commented 1 year ago

thanks - much appreciated.