search

langcog / metalab2

MetaLab -- Community-augmented meta-analysis
http://metalab.stanford.edu/
MIT License
21 stars 8 forks source link

negative d_var_calc? #105

Closed christinabergmann closed 4 years ago

christinabergmann commented 5 years ago

Some calculated variances seem negative, wanted to flag this for further investigation.

cissard commented 5 years ago

Can you specify the datasets that have this issue?

christinabergmann commented 5 years ago

I think I found it, it's in StatSeg in a Hay & Saffran entry, one of them has an impossible correlation over 1, so I am removing the correlation value. This fixes the issue.

Follow-up: We need to implement checks for correlations provided (eg by authors).

erikriverson commented 4 years ago

@christinabergmann could this be another check we do when validating the data, and reporting if there is an invalid correlation value? I will add it to the checks if so.

christinabergmann commented 4 years ago

These values are calculated but indeed, there can be a check whether the calculation makes sense. But first, I need to further track whether (1) this still happens and (2) it's not an error in our math. I'll update with affected datasets

erikriverson commented 4 years ago

check 'r' column for [-1, 1], add warning, same with corr

saraelshawa commented 4 years ago

fixed in metalabr package