search

langcog / metalab2

MetaLab -- Community-augmented meta-analysis
http://metalab.stanford.edu/
MIT License
21 stars 8 forks source link

use the here package for managing file paths #155

Closed erikriverson closed 4 years ago

erikriverson commented 4 years ago

This PR adds the here package for managing file paths for both the static-generated site and the Shiny applications.

mcfrank commented 4 years ago

yes, seems reasonable to me to delete that.

On Tue, May 5, 2020 at 8:59 AM Erik Iverson notifications@github.com wrote:

@erikriverson commented on this pull request.

In reports/hierarchicalrandomeffect_cache/html/__packages https://github.com/langcog/metalab2/pull/155#discussion_r420221475:

@@ -6,16 +6,15 @@ tidyr ggplot2

Should this file be deleted from the git repository? It looks like other _cache/ files are ignored in .gitignore, and perhaps this one snuck in on accident. It does seem to cause an issue as there are packages in the list that may not have been installed on the local machine as they do not appear in the package installer list. This leads to the building of the random effects paper to fail.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/langcog/metalab2/pull/155#pullrequestreview-405929836, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI25F4GBGQ7TM4NA73NQATRQAZUXANCNFSM4MZWEM3Q .