langcog / metalab2

MetaLab -- Community-augmented meta-analysis
http://metalab.stanford.edu/
MIT License
21 stars 8 forks source link

tutorials videos are too wide #40

Closed cissard closed 6 years ago

cissard commented 6 years ago

I think making the videos as wide as the window is too much. On the opposite the pictures are difficult to read because they are too small. If you agree I can modify these two.

shotsuji commented 6 years ago

Yes please!

christinabergmann commented 6 years ago

Seconded

mcfrank commented 6 years ago

I think we should actually format the whole tutorial tab so it's much less wide and hence more readable... the videos could come with this. :)

cissard commented 6 years ago

I've changed the names of the tabs, let me know what you think.

For the size of the videos I've made a first try on the first video based on the package doc. I'll check tomorrow if it works and if yes I will update the others.

shotsuji commented 6 years ago

@cissard I changed back some of the tab names - especially the first one did not work in English :) Have you succeeded with the videos? If I knit them locally the size is ok, I don't understand why they get so wide online (@amsan7 any hunch?)

@amsan7 if I want to change the width of the tutorial pages like Mike suggests, am I right to do so in pages/tutorials.Rmd?

amsan7 commented 6 years ago

adjusting width on tutorials.Rmd should be right - did it work for you?

shotsuji commented 6 years ago

How do I check that locally (since it won't reflect in individual Rmds)?

amsan7 commented 6 years ago

you should be able to cd into scripts and run Rscript main_builder.R which will produce html in the rendered folder. The tutorials.html page is there.

I did deploy your changes so you can see it online - looks like it's a bit too narrow so might want to try something in between: http://metalab.stanford.edu/tutorials.html

mcfrank commented 6 years ago

My though on this is that we want a single layout, centered and fixed width, for About / Tutorials / Documentation / Publications / Analyses. Note that Analyses and About already have a layout that has that property, so we just want to get the others doing the same thing.

On Sun, Jan 14, 2018 at 11:55 AM, Alessandro notifications@github.com wrote:

you should be able to cd into scripts and run Rscript main_builder.R which will produce html in the rendered folder. The tutorials.html page is there.

I did deploy your changes so you can see it online - looks like it's a bit too narrow so might want to try something in between: http://metalab.stanford.edu/tutorials.html

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/langcog/metalab2/issues/40#issuecomment-357537414, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGul1xYUI8H1dVCOpYfULivd-zVrsfVks5tKlu-gaJpZM4RS98o .

shotsuji commented 6 years ago

Ok that sounds good - @amsan7 will you be able to do this?

I am still having trouble with the video width though - although I specified a width in the tutorials (see why_do_a_MA.Rmd), when rendered the videos default to width of the tutorials page. I assume I'd need to change this in tutorials.Rmd somehow? This is not a crucial issue but it does look unprofessional.

cissard commented 6 years ago

Thanks Sho for correcting the tab names ! Le 14 janv. 2018 à 21:42, shotsuji notifications@github.com<mailto:notifications@github.com> a écrit :

Ok that sounds good - @amsan7https://github.com/amsan7 will you be able to do this?

I am still having trouble with the video width though - although I specified a width in the tutorials (see why_do_a_MA.Rmd), when rendered the videos default to width of the tutorials page. I assume I'd need to change this in tutorials.Rmd somehow? This is not a crucial issue but it does look unprofessional.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/langcog/metalab2/issues/40#issuecomment-357540725, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ae7x4xrt52tdw_2eZq354ner0Tj19A2oks5tKmbCgaJpZM4RS98o.

Cécile Issard Doctorante Laboratoire Psychologie de la Perception - UMR8242 Université Paris Descartes - CNRS http://lpp.parisdescartes.cnrs.fr 01.70.64.99.69 @CecileIcecile

christinabergmann commented 6 years ago

Hi @amsan7, might this in a code chunk work?

<iframe width="560" height="315" src="http://www.youtube.com/embed/9bZkp7q19f0?rel=0" frameborder="0" allowfullscreen></iframe>

(I am a bit confused about /embed/ versus feature=player_embedded in the video urls

via: https://stackoverflow.com/questions/46401154/embed-htmlwidget-of-external-webpage-in-r-markdown-html-document

amsan7 commented 6 years ago

interestingly the iframe stuff wasn't working for me but i decreased the width of page acc to @mcfrank 's suggestion, so that it looks more like Analyses

shotsuji commented 6 years ago

I also tried iframe - it works but again does not change the size of the videos in the rendered html (Alessandro, it has to be directly in the rmd not in a chunk, maybe that's why it didn't work for you? see updated why_do_a_MA.rmd)

I suspect we need to change something on a higher level, like in tutorials.Rmd, but have no idea how.

Although it looks stupid, if no one else has a hunch do we want to leave it as is for the launch?

christinabergmann commented 6 years ago

I think we either leave it or we simply link to the video instead of embedding it, both are fine with me. Thanks for all the work, @shotsuji and @amsan7. This is really annoying and fiddly :(

amsan7 commented 6 years ago

think i got it working - ugh sorry always blank out on frontend work. @shotsuji if you want to adjust size of videos just change iframe style params in pages/tutorials.Rmd

christinabergmann commented 6 years ago

Yesssss, looks great!

shotsuji commented 6 years ago

Excellent! I adjusted to standard frame size. Thank you!!

mcfrank commented 6 years ago

publications is now the only one with a different width, maybe we can do this one too as the rest look great?

On Tue, Jan 16, 2018 at 8:50 AM, shotsuji notifications@github.com wrote:

Excellent! I adjusted to standard frame size. Thank you!!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/langcog/metalab2/issues/40#issuecomment-358027137, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGul26FdyPQyGvr1cAcjVgDoDhc72JGks5tLNNzgaJpZM4RS98o .