langcog / metalab2

MetaLab -- Community-augmented meta-analysis
http://metalab.stanford.edu/
MIT License
21 stars 8 forks source link

Inconsistency in model specification - not critical but should be revisited #47

Open shotsuji opened 6 years ago

shotsuji commented 6 years ago

The "model" and "no_mod_model" functions are coded differently in server.R (e.g., "slab = make.unique(short_cite)" vs. "slab = make.unique(data()[["short_cite"]])".

Latter leads to awkward model variance component notation on visualizations page so should be dealt with at some point. Results are the same though.

@amsan7 and I checked that changing to notation without data() works fine, but haven't implemented it in case there's any specific reason to having implemented it this way.