langcog / tidyboot

tidyverse-compatible bootstrapping
21 stars 1 forks source link

Minor warnings related to tidyr > 1.0.0 compatibility #9

Closed hawkrobe closed 4 years ago

hawkrobe commented 4 years ago

After tidyr version 1.0.0, this warning is thrown:

`cols` is now required.
Please use `cols = c(strap)`

There is also now a tibble deprecation warning:

`as_data_frame()` is deprecated as of tibble 2.0.0.
Please use `as_tibble()` instead.
The signature and semantics have changed, see `?as_tibble`.
cjhook commented 4 years ago

It looks like the 'cols is now required' warning is from unnest():

https://tidyr.tidyverse.org/reference/nest_legacy.html

hawkrobe commented 4 years ago

see also the profiling in #8 (where the updated unnest() is also the source of the slowdown).

dyurovsky commented 4 years ago

fixed by 082557d4599607e458b876bdd48351b98376378c