langcog / web-cdi

7 stars 5 forks source link

add column in output that references 3rd edition (2023) norms #437

Closed vmarchman closed 1 year ago

vmarchman commented 1 year ago

@HenryMehta for all outputs downloaded after the new norming tables are implemented should have an additional column in the output: Header: Norms. Value: 3rd Edition.

HenryMehta commented 1 year ago

@vmarchman Is this a new column, or a footer or title? If column, how does it fit into the clinical reports?

vmarchman commented 1 year ago

Ok - you're right. A header or footer works best that can be applied to all csv outputs and clinical reports. So how about "3rd Edition (Marchman et al., 2023)"

On Fri, Apr 14, 2023 at 5:48 AM Henry Mehta @.***> wrote:

@vmarchman https://github.com/vmarchman Is this a new column, or a footer or title? If column, how does it fit into the clinical reports?

— Reply to this email directly, view it on GitHub https://github.com/langcog/web-cdi/issues/437#issuecomment-1508454806, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2TUTFXWRCWKS3QKGZ7HDTXBFBQNANCNFSM6AAAAAAW5NPVCM . You are receiving this because you were mentioned.Message ID: @.***>

HenryMehta commented 1 year ago

@vmarchman I think I've added a footer to all output and deployed to dev

vmarchman commented 1 year ago

Yup, it's there, but on the clinical report, it's on the 2nd page, so gets lost.

How about we put it as a header instead?

On Sat, Apr 15, 2023 at 2:55 AM Henry Mehta @.***> wrote:

@vmarchman https://github.com/vmarchman I think I've added a footer to all output and deployed to dev

— Reply to this email directly, view it on GitHub https://github.com/langcog/web-cdi/issues/437#issuecomment-1509711700, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2TUTENKFZD6Y42SFFISATXBJWCRANCNFSM6AAAAAAW5NPVCM . You are receiving this because you were mentioned.Message ID: @.***>

HenryMehta commented 1 year ago

@vmarchman I've made it display on every page

vmarchman commented 1 year ago

Ok - this is fine

On Tue, Apr 18, 2023 at 6:53 AM Henry Mehta @.***> wrote:

@vmarchman https://github.com/vmarchman I've made it display on every page

— Reply to this email directly, view it on GitHub https://github.com/langcog/web-cdi/issues/437#issuecomment-1513200086, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2TUTAFMHXYCDDMISK7463XB2MERANCNFSM6AAAAAAW5NPVCM . You are receiving this because you were mentioned.Message ID: @.***>