langcog / web-cdi

7 stars 5 forks source link

clinical reports use chronological age, not age to compare #475

Closed vmarchman closed 7 months ago

vmarchman commented 8 months ago

@HenryMehta In the csv outputs, when a child is born prematurely, you can ask for outputs with both chronological and adjusted benchmark ages. But, in the clinical report, there is only 1 option. That option gives you "Age to compare" that is the adjusted age, but then the percentiles are the non-adjusted ones.

Solution: Add new clinical report option with adjusted benchmarks, analogous to the csv output options. If you choose "Clinical Report" you get the chronological benchmarks - and the age to compare should be the same as chronological age and the percentiles are the unadjusted ones.

If you choose "Clinical Report with adjusted benchmarks" you get adjusted "Age to Compare" and the adjusted percentiles.

HenryMehta commented 8 months ago

@vmarchman deploying to dev now

vmarchman commented 8 months ago

Thanks @HenryMehta!! Tested in dev. Option for two clinical reports is in dropdown and works fine. But, both clinical reports are the same. That is, both use the chronological age percentiles. The "Clinical report" is correct since we want that one with the chronological age percentiles (and the Chronological age and Age to compare should be the same).

The "Clinical report with Adjusted Percentiles" is NOT correct. We want that one to spit out the adjusted benchmark percentiles. The Age to compare should be different than the Chronological age.

*Everything is correct in the csv outputs.

*Typo in label in dropdown - "Adjusted benchmarks"

HenryMehta commented 8 months ago

@vmarchman could you tell me which report you're testing on. I don't have data with different results

vmarchman commented 8 months ago

Hi @Henry @.***> I was testing with Study test WG, subject 1111, administration 25.

I'm using administration #26 to test the 0 responses (issue 481)

On Wed, Nov 8, 2023 at 7:12 AM Henry Mehta @.***> wrote:

@vmarchman https://github.com/vmarchman could you tell me which report you're testing on. I don't have data with different results

— Reply to this email directly, view it on GitHub https://github.com/langcog/web-cdi/issues/475#issuecomment-1802087432, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2TUTDTZB4R5HMHAAATBI3YDOONVAVCNFSM6AAAAAA6HR2EKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBSGA4DONBTGI . You are receiving this because you were mentioned.Message ID: @.***>

HenryMehta commented 8 months ago

@vmarchman try now

vmarchman commented 7 months ago

Yes - working now! Thanks @HenryMehta