langcog / web-cdi

7 stars 5 forks source link

remove "Centiment" option in demographics #482

Closed vmarchman closed 7 months ago

vmarchman commented 7 months ago

@HenryMehta Currently, the demographic options still have the "Centiment" option that we used for an earlier study. It's not working now so please remove this option from the demographics dropdown.

HenryMehta commented 7 months ago

@vmarchman deployed to Dev

HenryMehta commented 7 months ago

@vmarchman I don't see where you are still seeing Centiment option. I have removed it from the dropdown when creating/editing a study and cannot find it elsewhere

HenryMehta commented 7 months ago

@vmarchman found it - try now

vmarchman commented 7 months ago

@HenryMehta. Agree the option is gone from the Create study dialog. And, only the demographic options for that form are listed.

But in the UPDATE study dialog, you see all of the demographic options, including centiment and those that don't belong to that language form. that is, you see French_split.json, for example, when updating a study with English WG

HenryMehta commented 7 months ago

@vmarchman please check the Update dialog again. It does limit the demographic options but it has to load the page first and then do the limiting to those available so takes a few seconds (depending on how good your internet speed is)

vmarchman commented 7 months ago

@Henry @.***> it wasn't working in old studies, so I created a new study. Saved it, and then came back into Update study. All of the demographic options were there. Refreshed page. Options still there. [image: image.png]

On Fri, Nov 10, 2023 at 6:37 AM Henry Mehta @.***> wrote:

@vmarchman https://github.com/vmarchman please check the Update dialog again. It does limit the demographic options but it has to load the page first and then do the limiting to those available so takes a few seconds (depending on how good your internet speed is)

— Reply to this email directly, view it on GitHub https://github.com/langcog/web-cdi/issues/482#issuecomment-1805861107, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2TUTDACDXTPLHHCUHTAP3YDY33DAVCNFSM6AAAAAA7BVVKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVHA3DCMJQG4 . You are receiving this because you were mentioned.Message ID: @.***>

HenryMehta commented 7 months ago

@vmarchman Don't refresh the page. Give it 10 seconds or so and then check the options

vmarchman commented 7 months ago

@Henry @.***> I've waited like a minute and no difference :-(

On Fri, Nov 10, 2023 at 6:47 AM Henry Mehta @.***> wrote:

@vmarchman https://github.com/vmarchman Don't refresh the page. Give it 10 seconds or so and then check the options

— Reply to this email directly, view it on GitHub https://github.com/langcog/web-cdi/issues/482#issuecomment-1805875618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2TUTG5A5WDF4KSXYHWO5LYDY47PAVCNFSM6AAAAAA7BVVKBWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBVHA3TKNRRHA . You are receiving this because you were mentioned.Message ID: @.***>

HenryMehta commented 7 months ago

ok - strange since works for me. I'll take a look tomorrow

HenryMehta commented 7 months ago

@vmarchman Found the issue. It was limiting the demographic options if anything other than the default had been selected. But if the default was being used it wasn't limiting the options. Deploying fix to dev now