search

langcog / wordbankr

R package for accessing Wordbank
http://langcog.github.io/wordbankr/
30 stars 4 forks source link

how do you find out what instruments have unilemmas? #16

Closed mcfrank closed 5 years ago

mcfrank commented 6 years ago

seems like we need a column has_unilemmas in instruments like has_grammar? otherwise, what's the preferred call to find out if an instrument has them?

mikabr commented 6 years ago

this would need to get added in wordbank itself, wordbankr would preserve that column in get_instruments()

mcfrank commented 6 years ago

It would be great to have if someone wouldn't mind adding it?

Mike

On Wed, Feb 7, 2018 at 12:29 PM, Mika Braginsky notifications@github.com wrote:

this would need to get added in wordbank itself, wordbankr would preserve that column in get_instruments()

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/langcog/wordbankr/issues/16#issuecomment-363900131, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGul2T103Nmv0sNN5GjYKw3P4LArFyTks5tSgeZgaJpZM4RBQat .

daniellekellier commented 6 years ago

Since most of the instruments do not have 100% coverage with unilemmas, would it be more informative to just report the % of words covered under that instrument with get_instruments?

daniellekellier commented 6 years ago

Should be accessible via wordbankr. There is a pesky warning due to the field in wordbank being a DecimalField that has to be converted to R's numeric class. Apparently, it has to due with RMySQL and it won't go away. In the pull request #18, I wrote some code that suppresses that specific warning and would let through any other issue.