langel / botb_irc_bot

battle of the bits instant relay chat magic
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

ultrachord command pluck octave 9 crashes bot #44

Closed langel closed 8 years ago

langel commented 8 years ago

it was suggested that pluck might use a filter and it's choking on math which would mean there is a bug with the CLI tool we are utilizing

langel commented 8 years ago

from IRC --

[16:46] Does it use a LADSPA synth? [16:47] Because I highly doubt these plucks are native sox! [16:47] i don't remember if it was R3M or Savestate that figured that out [16:47] Oh wait it does have a native synth [16:48] Yeah I could probably try a range of plucks [16:48] and see if sox chokes on any [16:49] http://sox.sourceforge.net/Docs/Features <-- it says something about LADSPA on this page [16:49] i don't know what that is [16:49] == SketchMan3 [~brkbrkbrk@nc-76-3-211-77.dhcp.embarqhsd.net] has quit [Ping timeout: 183 seconds] [16:50] Yep [16:50] C:\Program Files (x86)\sox-14-4-2>sox -n B:/H/output.wav synth 3 pluck %-20 [16:50] C:\Program Files (x86)\sox-14-4-2>sox -n B:/H/output.wav synth 3 pluck %-40 [16:50] C:\Program Files (x86)\sox-14-4-2>sox -n B:/H/output.wav synth 3 pluck %-60 [16:50] sox FAIL synth: invalid freq [16:50] looks like a rabbit hole [16:50] Looks like the bot always expects sox to return sound [16:50] and crashes when sox returns an error instead [16:51] sox's pluck doesn't work with 60 semitones below A=440 Hz

jangler commented 8 years ago

What's an example of a command that causes this to happen?

ianremsen commented 8 years ago

since commands no longer crash the bot, it just doesn't work now

langel commented 8 years ago

using pluck with octave 9 breaks it

jangler commented 8 years ago

I had been trying the syntax from the old help message (;uc <notes> [timbre]) instead of the actual syntax (;uc [timbre] <notes>). Can reproduce now.

jangler commented 8 years ago

As mentioned in IRC, it's an apparently intentional limitation of SoX, so not really a bug. Best to have the bot just yell at you if you try to pluck too high.

langel commented 8 years ago

great investigations!