search

langel / botb_irc_bot

battle of the bits instant relay chat magic
BSD 3-Clause "New" or "Revised" License
11 stars 7 forks source link

ES6ified + Fixed 'days_to_fulldate' Function #63

Closed Savestate2A03 closed 7 years ago

Savestate2A03 commented 7 years ago

Ok! Take 2...

I was looking at the Network Graph, and as far as I can tell, it looks like everyone is caught up with it (sans sleeparrow, whose fork was already implemented)

Now would be the time to merge, and from there to continue the bot development with ES6 in mind.

jangler commented 7 years ago

I have node v6.7.0 and the string interpolation doesn't seem to work for me:

brandon@desk ~ $ node --version
v6.7.0
brandon@desk ~ $ node
> x = 4
4
> '${x}'
'${x}'
Savestate2A03 commented 7 years ago

Make sure to use backticks! console.log(${x}) It looks like you're using single quotation marks

jangler commented 7 years ago

Ah, cool, thanks. Works for me.

langel commented 7 years ago

there is so much about this I find cringey been using semicolons my whole life and now they're unnecessary? let replaces var but did var being block scoped change? bash CLI style back tick variable string insertion because + concatenation looks like math? but the thing that really messes with my head are these arrow functions... "javascript sucks because it's loosely typed" "yeah, well at least you don't need to declare functions with the function type label now" i seriously don't understand what is gained by this evolution other than obfuscated meaning and looking cool; people read left to right but the arrow is after the parameters; looks like a bastard ternary conditional that takes a code block for an operator i'm late for a thing, should be back home in some hours, will try to let this all sink in

langel commented 7 years ago

I've had time to marinate. Once my coworkers explained that arrow functions utilize the 'penis operator' I fell in love. I'm still not sold on the missing semicolons. Too tired to pull and run; will prolly do so at work tomorrow.

langel commented 7 years ago

Alright, I've adopted the penis operator into my lexicon.
Still not too sure about dropping the semicolons. They were never ES spec demanded in the first place, but I kinda like them.

Savestate2A03 commented 7 years ago

I see removing them as just another thing to not worry about. Glad the merge worked out!

Sorry for taking all the blame Jangler.