Added vibration option in App Overrides

ahmed-shehata commented 3 months ago

This allows the user to select the vibration strength per app/game

This PR changes

miguelguzmanr commented 2 months ago

Thank you for taking the time to submit a pull request! Some concerns:

Current implementation of changing the vibration strength is exclusive to (only works for) the Odin2. Let's consider disabling/hiding this per-app setting for non-Odin2 devices.
Changing the vibration strength via the main screen uses a slider to manually assign a preferred value. Meanwhile, this per-app setting changes the vibration strength between preset values (Low, Mid, High). I like this, but let's consider if consistency is required or not e.g. main screen should also work with preset values.
This per-app setting changes the vibration strength. However, if vibration isn't enabled, it will not work. Let's consider the "vibrate_on" system setting, which is currently used in the main screen to enable/disable vibration.

@langerhans Please let us know your thoughts as well!

ahmed-shehata commented 1 month ago

@miguelguzmanr Thanks a lot for the review, I've changed the option to be numeric instead for better customizability:

Screenshot 2024-05-16 at 11 27 53 pm