langerhans / multidoge

MultiDoge is a desktop Dogecoin client, powered by dogecoinj. Ported from the MultiBit Bitcoin client.
http://multidoge.org
MIT License
257 stars 110 forks source link

Default Key Date is way in the past #53

Closed h4ck3rm1k3 closed 6 years ago

h4ck3rm1k3 commented 6 years ago

The issue is that the key createdAt date is 6 months in the past 2016-05-20T07:33:18Z and not today for keys created now.

How to reproduce :

  1. Download multidoge 0.1.7 http://multidoge.org/ from https://github.com/langerhans/multidoge/releases/download/v0.1.7/multidoge-0.1.7-linux.jar

  2. Start and Create a new wallet image

  3. Select the new wallet image

  4. Select export wallet image

  5. Export Turn off password for the test image

  6. Check the key

    
    # KEEP YOUR PRIVATE KEYS SAFE !
    # Anyone who can read this file can spend your dogecoin.
    #
    # Format:
    #   <Base58 encoded private key>[<whitespace>[<key createdAt>]]
    #
    #   The Base58 encoded private keys are the same format as
    #   produced by the Satoshi client/ sipa dumpprivkey utility.
    #
    #   Key createdAt is in UTC format as specified by ISO 8601
    #   e.g: 2011-12-31T16:42:00Z . The century, 'T' and 'Z' are mandatory
    #
    QTFj<redacted>EZPb5DU 2016-05-20T07:33:18Z


The issue is that the key createdAt date is 6 months in the past 2016-05-20T07:33:18Z and not today.

<br /><hr/><em>Posted on <a href="https://utopian.io/utopian-io/@h4ck3rm1k3st33m/default-key-date-is-way-in-the-past">Utopian.io -  Rewarding Open Source Contributors</a></em><hr/>
langerhans commented 6 years ago

Your blockchain was not synced at the time you did an export. Given this condition your observation is expected behavior. The comment here explains what happens: https://github.com/langerhans/multidoge/blob/master/src/main/java/org/multibit/file/PrivateKeysHandler.java#L317-L339

Thanks for the detailed report tho!

h4ck3rm1k3 commented 6 years ago

I just wanted to import my keys like described here https://www.reddit.com/r/dogecoin/comments/1ycd5u/how_to_import_your_dogecoinqt_wallet_into/ what I was missing was this timestamp if I used the old one for my keys will take forever to import so really I want some instructions or comments in that file that might help the next poor guy.