langgenius / dify

Dify is an open-source LLM app development platform. Dify's intuitive interface combines AI workflow, RAG pipeline, agent capabilities, model management, observability features and more, letting you quickly go from prototype to production.

https://dify.ai

Other

51.82k stars 7.51k forks source link

Fix: Set Celery LOG_File only when available, always log to console #10563

Closed fdb02983rhy closed 5 days ago

fdb02983rhy commented 5 days ago

Checklist:

[!IMPORTANT]
Please review the checklist below before submitting your pull request.

[x] Please open an issue before creating a PR or link to an existing issue
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fix #10555 Regarding Celery, only set the LOG_FILE variable to Difyconfig when its available. Besides, always log output to the console.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Fix the code, rebuild worker image, run docker compose.

yuzp-work commented 4 days ago

Is this issue fixed? Trying to update from 0.10.1 to 0.11.1 in docker, looks still have this issue.

verigle commented 4 days ago

not fix for 0.11.1

fdb02983rhy commented 4 days ago

It happens after you update to 0.11.1, it should be fixed in the next release with this PR.

crazywoola commented 1 day ago

https://github.com/langgenius/dify/issues/10555#issuecomment-2470651673