Dify is an open-source LLM app development platform. Dify's intuitive interface combines AI workflow, RAG pipeline, agent capabilities, model management, observability features and more, letting you quickly go from prototype to production.
The deployment name of our o1 model is 'gpt-o1'. When adding the model, we encountered an error: "Unsupported parameter: 'max_tokens' is not supported with this model. Use 'max_completion_tokens' instead." After reviewing the code, we found that the logic checks if the model name starts with 'o1'. If the deployment name doesn't start with 'o1', the model cannot be added properly. Therefore, the logic should be changed to check if 'o1' exists anywhere in the model name instead of just at the beginning.
Type of Change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update, included: Dify Document
[ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
[ ] Dependency upgrade
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
Fix https://github.com/langgenius/dify/issues/9746
The deployment name of our o1 model is 'gpt-o1'. When adding the model, we encountered an error: "Unsupported parameter: 'max_tokens' is not supported with this model. Use 'max_completion_tokens' instead." After reviewing the code, we found that the logic checks if the model name starts with 'o1'. If the deployment name doesn't start with 'o1', the model cannot be added properly. Therefore, the logic should be changed to check if 'o1' exists anywhere in the model name instead of just at the beginning.
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration