Closed aixgeek closed 2 months ago
After clearing the variable type, selecting the type again will result in an error.
fixed
@zxhlyh dify outputs panel have two bugs:
I have fixed these bugs.
@VincePotato Do you think it's necessary to auto rename the variable name when it's duplicate?
@iamjoel add a duplicate will cause a serious bug. Steps to Reproduce: 1.add a var, it has same name 2.delete this var, it will delete the same var's type 3.can't choose var's type
@iamjoel add a duplicate will cause a serious bug. Steps to Reproduce: 1.add a var, it has same name 2.delete this var, it will delete the same var's type 3.can't choose var's type
I'll fix the bug later.
@VincePotato Do you think it's necessary to auto rename the variable name when it's duplicate?
I think we should notify and guide users to rename instead of automatically creating names, as automatically generated names usually lack distinctiveness.
@VincePotato @iamjoel This pr is not rename the variable name. The major job is fix validate in change event.
duplicate name problem is a extra work, it fix some problems.
@iamjoel add a duplicate will cause a serious bug. Steps to Reproduce: 1.add a var, it has same name 2.delete this var, it will delete the same var's type 3.can't choose var's type 添加重复项会导致严重的错误。重现步骤: 1.添加一个var,它具有相同的名称 2.删除这个var,它将删除相同的var类型 3.不能选择var的类型
I'll fix the bug later.稍后我会修复该错误。
Fixed with https://github.com/langgenius/dify/pull/5845/files
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # 5625
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsoptional
I have made corresponding changes to the documentationoptional
I have added tests that prove my fix is effective or that my feature worksoptional
New and existing unit tests pass locally with my changes