langgenius / dify

Dify is an open-source LLM app development platform. Dify's intuitive interface combines AI workflow, RAG pipeline, agent capabilities, model management, observability features and more, letting you quickly go from prototype to production.
https://dify.ai
Other
45.3k stars 6.36k forks source link

Upgrade Tutorial is wrong #6189

Closed pourmand1376 closed 2 months ago

pourmand1376 commented 2 months ago

Self Checks

Provide a description of requested docs changes

Hi. Thanks for creating this great platform.

Today, I upgraded my Dify Docker Installation and I came along with the issue that docker compose down didn't delete my docker containers.

I think the problem is that first we update the repo, and then we use docker compose down which should be the opposite.

If we make any changes to docker-compose.yaml, docker compose wouldn't know it is related to the services.

dosubot[bot] commented 2 months ago

Hello there, @pourmand1376! I'm here to help you with any bugs, questions, or contributions you have. Let's tackle this issue together!

The upgrade tutorial for the Dify Docker Installation already includes the step to first run docker compose down before updating the repository. Here is the relevant section from the document:

### Difyの更新

difyソースコードのdockerディレクトリに入り、以下のコマンドを順に実行:

```bash
cd dify/docker
git pull origin main
docker compose down
docker compose pull
docker compose up -d


This ensures proper container management during the upgrade process <sup>[[1]](https://github.com/langgenius/dify-docs/blob/main/en/getting-started/install-self-hosted/docker-compose.md)</sup><sup>[[2]](https://github.com/langgenius/dify-docs/blob/main/jp/getting-started/install-self-hosted/docker-compose.md)</sup>.

<!-- Dosu Comment Footer -->
*To continue talking to [Dosu](https://dosu.dev), mention @dosu.*
crazywoola commented 2 months ago

The docs below only applies to a normal upgrade process.

cd dify/docker
git pull origin main
docker compose down
docker compose pull
docker compose up -d

For detailed information regarding how to upgrade. Please see our release logs, for example in our v0.6.12 https://github.com/langgenius/dify/releases/tag/0.6.12, we have highlighted those actions need to be done already.

pourmand1376 commented 2 months ago

OK. I am saying that if you guide people to do:

cd dify/docker
docker compose down
git pull origin main
docker compose pull
docker compose up -d

A lot less people would have issues! It is only a matter of changing two lines in the upgrade documentation.

crazywoola commented 2 months ago

Yes thanks for your suggestions :) https://github.com/langgenius/dify-docs/blob/main/en/getting-started/install-self-hosted/docker-compose.md Already updated