Self Checks

[X] This is only for bug report, if you would like to ask a question, please head to Discussions.
[X] I have searched for existing issues search for existing issues, including closed ones.
[X] I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
[X] [FOR CHINESE USERS] 请务必使用英文提交 Issue，否则会被关闭。谢谢！:）
[X] Please do not modify this template :) and fill in all the required fields.

Dify version

0.8

Cloud or Self Hosted

Self Hosted (Source)

Steps to reproduce

✔️ Expected Behavior

Issue Description: The code logic for handling the "retriever_resources" key in the metadata dictionary is incorrect. Specifically: The code checks if "retriever_resources" exists in metadata. If it exists, it clears the list. It then iterates over and rebuilds the list. Problem Reason: The list is cleared before iteration, causing the subsequent loop to have no effect because the list is empty. Suggested Fix: Remove the operation that clears the list to preserve the existing data structure. Iterate and rebuild the list as needed. Relevant Code Snippet: if "retriever_resources" in metadata:

This line clears the list

metadata["retriever_resources"] = []
for resource in metadata["retriever_resources"]:
    metadata["retriever_resources"].append(
        {
            "segment_id": resource["segment_id"],
            "position": resource["position"],
            "document_name": resource["document_name"],
            "score": resource["score"],
            "content": resource["content"],
        }
    )

Suggested Modified Code: if "retriever_resources" in metadata: updated_resources = [] for resource in metadata["retriever_resources"]: updated_resources.append( { "segment_id": resource["segment_id"], "position": resource["position"], "document_name": resource["document_name"], "score": resource["score"], "content": resource["content"], } ) metadata["retriever_resources"] = updated_resources

langgenius / dify

api/core/app/apps/base_app_generate_response_converter.py:71 _get_simple_metadata #8607