langgenius / dify

Dify is an open-source LLM app development platform. Dify's intuitive interface combines AI workflow, RAG pipeline, agent capabilities, model management, observability features and more, letting you quickly go from prototype to production.
https://dify.ai
Other
51.81k stars 7.51k forks source link

fix: Count exception occurs when searching conversations #8754

Closed Gaocarri closed 1 month ago

Gaocarri commented 1 month ago

Checklist:

[!IMPORTANT]
Please review the checklist below before submitting your pull request.

Description

count-error

When using keyword to query conversations, multiple messages with unique conversation.id will be queried, resulting in an incorrect number of final query results (less than limit: 10)

Fix: #7964

Type of Change

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Gaocarri commented 1 month ago

@laipz8200 hey, could u review it ?

laipz8200 commented 1 month ago

I can confirm that this is a bug. However, adding a group by clause might lead to performance issues, so we need to run some tests.

Gaocarri commented 1 month ago

I can confirm that this is a bug. However, adding a group by clause might lead to performance issues, so we need to run some tests.

ok, if it has performance issues plz let me know the results

laipz8200 commented 1 month ago

@Gaocarri Thank you for your contribution!