Dify is an open-source LLM app development platform. Dify's intuitive interface combines AI workflow, RAG pipeline, agent capabilities, model management, observability features and more, letting you quickly go from prototype to production.
[!IMPORTANT]
Please review the checklist below before submitting your pull request.
[ ] Please open an issue before creating a PR or link to an existing issue
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
Description
Currently, in the base_callback module, the Callback class includes four methods: on_before_invoke, on_new_chunk, on_after_invoke, and on_invoke_error. The implementations of these methods simply raise a NotImplementedError. However, the inheriting class, LoggingCallback, has overridden all of these methods. In order to facilitate future expansion by users, it is suggested to refactor this class into an abstract class, thereby making it mandatory for its subclasses to implement these methods.
Fixes
Type of Change
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update, included: Dify Document
[x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
[ ] Dependency upgrade
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
Currently, in the base_callback module, the Callback class includes four methods: on_before_invoke, on_new_chunk, on_after_invoke, and on_invoke_error. The implementations of these methods simply raise a NotImplementedError. However, the inheriting class, LoggingCallback, has overridden all of these methods. In order to facilitate future expansion by users, it is suggested to refactor this class into an abstract class, thereby making it mandatory for its subclasses to implement these methods.
Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration