Make password confirmation optional (but true by default) in register

langleyfoxall / laravel-nist-password-rules

🔒 Laravel validation rules that follow the password related recommendations found in NIST Special Publication 800-63B section 5.

GNU Lesser General Public License v3.0

208 stars 49 forks source link

Make password confirmation optional (but true by default) in register #30

Closed ziming closed 3 years ago

ziming commented 4 years ago

There has been more and more sites where the register page don't ask you to confirm password. Trusting that you can always rely on the reset password functionality if you forget your password.

Hence this PR make password confirmation optional (but true by default to not break backward compatibility).

Needed this in a recent site I'm building :).

Thank you.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 108

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 105:	0.0%
Covered Lines:	75
Relevant Lines:	75

💛 - Coveralls

dextermb commented 4 years ago

This seems reasonable to me :+1:

cc: @DivineOmega

ziming commented 4 years ago

I think the argument variable name ($confirmation) can be better but I leave that task to you guys :)

I was thinking of $confirmPassword currently