Use Laravel own uncompromised pswd rule & support laravel 9 too.

langleyfoxall / laravel-nist-password-rules

🔒 Laravel validation rules that follow the password related recommendations found in NIST Special Publication 800-63B section 5.

GNU Lesser General Public License v3.0

208 stars 49 forks source link

Use Laravel own uncompromised pswd rule & support laravel 9 too. #44

Closed ziming closed 2 years ago

ziming commented 2 years ago

Laravel 8.39 onwards added its own uncompromised password check so we can eliminate some code

https://laravel-news.com/password-validation-rule-object-in-laravel-8

Laravel 8 requires PHP 7.3 minimum. However PHP 7.3 is now EOL so I bumped the PHP minimum of this package to ^7.4||^8.0

Since Laravel 9 is coming out very soon I also changed the laravel requirements to ^8.39||^9.0

Laravel 9 minimum is PHP 8.0.2

Testbench version is also bumped to support Laravel 8 & 9

Given the breaking changes, this can be tagged as a new major version.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 136

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 128:	0.0%
Covered Lines:	73
Relevant Lines:	73

💛 - Coveralls

SteJaySulli commented 2 years ago

We appreciate the suggestions here - Unfortunately removing support for EOL PHP versions and relying on features only available in latter 8.0 versions of Laravel could negatively effect legacy applications relying on this package, so at this time we are not going to merge this PR - We will, however, review these suggestions inline with ongoing development with a view to adopting them at the next opportunity.