Changes to support Laravel 9

langleyfoxall / laravel-nist-password-rules

🔒 Laravel validation rules that follow the password related recommendations found in NIST Special Publication 800-63B section 5.

GNU Lesser General Public License v3.0

208 stars 49 forks source link

Changes to support Laravel 9 #50

Closed SteJaySulli closed 2 years ago

SteJaySulli commented 2 years ago

This PR is pending a test in place within a Laravel 9 project

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 139

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 128:	0.0%
Covered Lines:	64
Relevant Lines:	64

💛 - Coveralls

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 139

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 128:	0.0%
Covered Lines:	64
Relevant Lines:	64

💛 - Coveralls

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 147

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 128:	0.0%
Covered Lines:	64
Relevant Lines:	64

💛 - Coveralls

zakini commented 2 years ago

What's left to do to get this PR merged? Does it only need testing in Laravel 9? I'd be happy to work on any outstanding tasks myself to get this sorted

LNCH commented 2 years ago

@Zakini I've planned in for this PR to be finalised today, should be able to have this merged soon for you

LNCH commented 2 years ago

@Zakini Merged, have fun! Let us know if anything doesn't work as you're using it!

zakini commented 2 years ago

Amazing 🙌 cheers for sorting this!