search

langleyfoxall / xero-laravel

💸 Access the Xero accounting system using an Eloquent-like syntax
https://packagist.org/packages/langleyfoxall/xero-laravel
GNU Lesser General Public License v3.0
85 stars 40 forks source link

[SUGGESTION] Remove need for config file #40

Open emp-sean opened 3 years ago

emp-sean commented 3 years ago

Hiya, just a suggestion to remove an install step and keep things cleaner would be to remove the need for the config file and just use laravels services config file, placing the information in there (obviously still referencing the env file).

acirinelli commented 3 years ago

Hiya, just a suggestion to remove an install step and keep things cleaner would be to remove the need for the config file and just use laravels services config file, placing the information in there (obviously still referencing the env file).

This is a solid idea as long as there are no additional parameters to configure (right now there are not). Leaving it as is provides more flexibility for the future or custom configuration.