langri-sha / screeps-webpack-plugin

Bundle and push your AI to Screeps servers
MIT License
5 stars 4 forks source link

Don't include trailing ".js" as part of module name #28

Closed bryanbecker closed 7 years ago

bryanbecker commented 7 years ago

Original version required the webpack output file to be "main" in order to upload as module main, but this makes integrating with other webpack features frustrating.

This change allows files to have .js extensions (ex. main.js), while still uploading with module name main

codecov-io commented 7 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #28   +/-   ##
======================================
  Coverage    93.1%   93.1%           
======================================
  Files           1       1           
  Lines          58      58           
======================================
  Hits           54      54           
  Misses          4       4
Impacted Files Coverage Δ
index.js 93.1% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5d29c9...9b2f951. Read the comment docs.

langri-sha commented 7 years ago

Awesome, thanks @bryanbecker!