langserver / langserver.github.io

http://langserver.org
202 stars 182 forks source link

Reconsider the inclusion of non-free intelephense server #283

Closed ambadyanands closed 2 years ago

ambadyanands commented 2 years ago

Hi,

First of all thanks for this community-driven project. At langserver.org, it states that the servers and clients must be fully open-source in order to qualify to be included on the list. Listing intelephense server violates this condition and I kindly request to remove the same by reverting https://github.com/langserver/langserver.github.io/commit/b6f8a1ded331233a107f991b7f8efb5d6cb331cc. Thanks again.

kskarthik commented 2 years ago

I also back this proposal

keegancsmith commented 2 years ago

FYI @beyang @sqs we state the servers needs to be OSS to be included. This seems like a position we should keep, but ccing you just in case you think it makes sense to change our conditions of inclusion. For now I will accept the revert.

Also cc @juliardi since he added the listing. I'm happy to change the decision after some debate. But for now I am going ahead with the revert.

juliardi commented 2 years ago

Although I am an avid supporter of open source, I am a bit baffled by Langserver's policy of only listing open source product. I will abide by your decision, but I hope Langserver can be a resource of information for finding Language Server tools regardless of license.

ambadyanands commented 2 years ago

I hope Langserver can be a resource of information for finding Language Server tools regardless of license.

@juliardi Hi, given that there is already such a list at https://microsoft.github.io/language-server-protocol/implementors/servers/, wouldn't that make this project redundant? What makes langserver project important, I believe, is its policies.

jdorfman commented 2 years ago

@juliardi @ambadyanands hypothetical, if we (Sourcegraph) donated this project to the community where new policies and governance could be established would this help the move this project forward?